Skip to content

Conversation

@rkirtir
Copy link
Contributor

@rkirtir rkirtir commented May 5, 2023

What changes were proposed in this pull request?

Fix TestWarehouseExternalDir

Why are the changes needed?

TestWarehouseExternalDir was flaky

Does this PR introduce any user-facing change?

NO

How was this patch tested?

http://ci.hive.apache.org/job/hive-flaky-check/679/
http://ci.hive.apache.org/job/hive-flaky-check/680/
http://ci.hive.apache.org/job/hive-flaky-check/681/

@rkirtir
Copy link
Contributor Author

rkirtir commented May 5, 2023

This test was tested via flaky test
http://ci.hive.apache.org/job/hive-flaky-check/681/

@rkirtir rkirtir changed the title Hive 25266 : Fix TestWarehouseExternalDir HIVE-25266 : Fix TestWarehouseExternalDir May 5, 2023
HIVE-25266 : Fix TestWarehouseExternalDir

HIVE-25266 : Fix TestWarehouseExternalDir

HIVE-25266 : Fix TestWarehouseExternalDir

HIVE-25266 : Fix TestWarehouseExternalDir

HIVE-25266 : Fix TestWarehouseExternalDir
@rkirtir rkirtir changed the title HIVE-25266 : Fix TestWarehouseExternalDir HIVE-25266: Fix TestWarehouseExternalDir May 5, 2023
@aturoczy
Copy link

aturoczy commented May 6, 2023

LGTM

@aturoczy
Copy link

I think it needs to be retrigger. Seems like this test is flaky:

java.util.NoSuchElementException
at java.util.LinkedList.getLast(LinkedList.java:257)
at org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testSizeOfDatabaseReplication(TestReplicationScenariosAcidTables.java:3980)
at org.apache.hadoop.hive.ql.parse.TestReplicationScenariosAcidTables.testSizeOfDatabaseReplicationViaDistCp(TestReplicationScenariosAcidTables.java:3911)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@veghlaci05 veghlaci05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veghlaci05 veghlaci05 merged commit 227db3d into apache:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants