HIVE-27332: Add retry backoff mechanism for abort cleanup #4313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
SourabhBadhya
changed the title
veghlaci05
reviewed
May 16, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
...alone-metastore/metastore-server/src/main/sql/derby/upgrade-4.0.0-alpha-2-to-4.0.0.derby.sql
Outdated
Show resolved
Hide resolved
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
kgyrtkirk
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
deniskuzZ
reviewed
May 22, 2023
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/AbortedTxnCleaner.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 22, 2023
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/TaskHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 22, 2023
...tore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
Show resolved
Hide resolved
deniskuzZ
reviewed
May 22, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
May 22, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests failed
tests pending
tests unstable
tests passed
and removed
tests pending
tests failed
tests unstable
labels
deniskuzZ
reviewed
Jun 7, 2023
...ore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/hive_metastore.proto
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 7, 2023
| try { | ||
| dbConn = getDbConn(Connection.TRANSACTION_READ_COMMITTED, connPoolCompaction); | ||
| if (!isAbortOnly) { | ||
| if (!info.isAbortedTxnCleanup()) { |
Member
There was a problem hiding this comment.
we no longer generate completed_compactions entries for the aborts, right?
Contributor
Author
There was a problem hiding this comment.
Yes, we no longer generate completed_compactions entries.
Member
There was a problem hiding this comment.
previously in case of unexpected situation, we were able to figure out the affected tables from the DB, now we'll have to grep the logs. should be fine, right?
Contributor
Author
There was a problem hiding this comment.
@deniskuzZ I think so. The logs should be fine here.
Also the logs will be under a separate class - AbortedTxnCleaner. So grepping this, should provide most information regarding what AbortedTxnCleaner does.
deniskuzZ
reviewed
Jun 7, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 7, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 7, 2023
Member
deniskuzZ
left a comment
deniskuzZ
left a comment
There was a problem hiding this comment.
@SourabhBadhya looks great! thanks, just 2 minor comments
deniskuzZ
reviewed
Jun 7, 2023
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/AbortedTxnCleaner.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Jun 7, 2023
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
Show resolved
Hide resolved
deniskuzZ
approved these changes
Jun 8, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add retry backoff mechanism for abort cleanup
Why are the changes needed?
To add retry backoff mechanism for abort cleanup
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests