HIVE-27337: Trim the starting and trailing white spaces in HMS for cr… #4316
Conversation
…eate and alter queries
...ne-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
Looks like the failed tests related... cloud you please check them? |
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
| POSTHOOK: Input: default@hbase_table_test_1 | ||
| POSTHOOK: Output: database:default | ||
| POSTHOOK: Output: default@VIEW_HBASE_TABLE_TEST_1 | ||
| POSTHOOK: Lineage: VIEW_HBASE_TABLE_TEST_1.ccount SIMPLE [(hbase_table_test_1)hbase_table_test_1.FieldSchema(name:ccount, type:int, comment:), ] |
There was a problem hiding this comment.
nit: do you know why these are converted to lowercased, we don't change the HS2 side.
There was a problem hiding this comment.
This is a Post Executor hook, this hook pulls out the metadata info from HMS and prints it out. So this is a expected change.
| + " already exists"); | ||
| } | ||
|
|
||
| tbl.setDbName(normalizeIdentifier(tbl.getDbName())); |
There was a problem hiding this comment.
The lineage info will feed into downstream project, so I'm a little nervous when the info changes.
I think we can make changes here like:
Table tbl = new Table(req.getTable());
tbl.setDbName(normalizeIdentifier(tbl.getDbName()));
tbl.setTableName(normalizeIdentifier(tbl.getTableName()));There was a problem hiding this comment.
It tried to implement your suggestion but 29 tests are failing because the tests are doing assert on the Table to construct a table path or table SD or something that is expected to be modified in HMS. So I think this change is not necessary.
Having changes in qfile files that change lineage info (which is anyway expected) is far better than changing 29 tests to do something else. Thanks.
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
saihemanth-cloudera
force-pushed
the
hive-27337
branch
from
eebb03e to
0ad5061
Compare
kgyrtkirk
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
|
Kudos, SonarCloud Quality Gate passed!
|
…eate and alter queries (apache#4316) (Sai Hemanth G, Reviewed by Zhihua Deng, Attila Turoczy)
…eate and alter queries (apache#4316) (Sai Hemanth G, Reviewed by Zhihua Deng, Attila Turoczy)
4 participants
…eate and alter queries
What changes were proposed in this pull request?
Trimming the white spaces if provided in create and alter queries.
Why are the changes needed?
If the users are providing white spaces, the queries should execute without issues.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual testing. Will add unit tests in the next commit.