-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27345: Upgrade commons-dbcp2 to 2.9.0 #4325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aturoczy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
There is 1 test failure of: TestHiveMetaStoreTimeout#testResetTimeout and there is already a PR(#4328) HIVE-27343 for fixing this flaky test. Rest all the UT are passing. |
|
you need to trigger the tests again and get a green build, we don't merge to master without a green build, even the failure is known to be not related. painful but unfortunately that is how things are... |
|
Kudos, SonarCloud Quality Gate passed! |
|
@ayushtkn, all the tests have passed 👍🏻 |
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
…(Raghav Aggarwal, reviewed by Ayush Saxena, Attila Turoczy)
…(Raghav Aggarwal, reviewed by Ayush Saxena, Attila Turoczy)









What changes were proposed in this pull request?
Upgrading commons-dbcp2 to 2.9.0
Why are the changes needed?
To be on the latest version of commons-dbcp2
Does this PR introduce any user-facing change?
No
How was this patch tested?
Ran the Unit test of standalone-metastore/metastore-server on local machine