Skip to content

Conversation

@Aggarwal-Raghav
Copy link
Contributor

What changes were proposed in this pull request?

Upgrading commons-dbcp2 to 2.9.0

Why are the changes needed?

To be on the latest version of commons-dbcp2

Does this PR introduce any user-facing change?

No

How was this patch tested?

Ran the Unit test of standalone-metastore/metastore-server on local machine

@Aggarwal-Raghav Aggarwal-Raghav changed the title HIVE-27345: Upgrade commons-dbcp2 to 2.9.0 to fix CVE HIVE-27345: Upgrade commons-dbcp2 to 2.9.0 May 15, 2023
Copy link

@aturoczy aturoczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Aggarwal-Raghav
Copy link
Contributor Author

There is 1 test failure of: TestHiveMetaStoreTimeout#testResetTimeout and there is already a PR(#4328) HIVE-27343 for fixing this flaky test. Rest all the UT are passing.

@ayushtkn
Copy link
Member

you need to trigger the tests again and get a green build, we don't merge to master without a green build, even the failure is known to be not related.

painful but unfortunately that is how things are...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Aggarwal-Raghav
Copy link
Contributor Author

@ayushtkn, all the tests have passed 👍🏻

Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@ayushtkn ayushtkn merged commit 8f2ee8b into apache:master May 20, 2023
yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
…(Raghav Aggarwal, reviewed by Ayush Saxena, Attila Turoczy)
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
…(Raghav Aggarwal, reviewed by Ayush Saxena, Attila Turoczy)
@Aggarwal-Raghav Aggarwal-Raghav deleted the dbcp2-upgrade branch October 10, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants