HIVE-27330: Compaction entry dequeue order #4327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
aturoczy
approved these changes
May 16, 2023
aturoczy
left a comment
aturoczy
left a comment
There was a problem hiding this comment.
Now it is plus 1 :) Wait for the green check 👍
kokila-19
approved these changes
May 17, 2023
Contributor
|
LGTM |
kasakrisz
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Compaction requests are now dequeued ordered by their id ascending
Why are the changes needed?
The unordered dequeue resulted in unpredictable process order.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually and through unit tests