HIVE-27348: Encode database name when generating database path #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schiller-oliver
changed the title
aturoczy
suggested changes
May 16, 2023
...one-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
aturoczy
reviewed
May 16, 2023
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
@aturoczy Would you be able to give me some hint what's necessary to make some progress with this PR? I'm new to this community, thus I don't know whom to ping to get some official review (and approval :)). |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR encodes that database name when using it to generate the default database path. For this purpose, the method
MetaStoreUtils.encodeTableNameis used. This is analogous to how table names are encoded when used to generate the default path for a table.Why are the changes needed?
If the database name is not encoded, special characters which are allowed in schema names are used as is in the path. This causes problems in cases where these special characters are not allowed. One example being URI generation from the database path.
Does this PR introduce any user-facing change?
The default location for a database change in case the database name contains special characters. For example,
my{schema}resulted in "my{schema}.db", now it results in "my-123-schema-125-.db".How was this patch tested?
I've extended the name of the schema created in test special_character_in_tabnames_1.q such that it contains additional, problematic characters. Without the fix, the modified test case fails, with the fix, the modified test case runs clean.