HIVE-27352: Support both LDAP and Kerberos Auth in HS2 #4331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests pending
tests failed
tests unstable
and removed
tests passed
tests pending
tests failed
labels
dengzhhu653
force-pushed
the
HIVE-27352
branch
2 times, most recently
from
fd32173 to
606ed77
Compare
kgyrtkirk
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHS2JWTWithMiniKdc.java
Outdated
Show resolved
Hide resolved
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
saihemanth-cloudera
left a comment
saihemanth-cloudera
left a comment
There was a problem hiding this comment.
Mostly looks good, I will approve once the clarification on the review comment is resolved.
saihemanth-cloudera
approved these changes
Jun 5, 2023
Contributor
saihemanth-cloudera
left a comment
saihemanth-cloudera
left a comment
There was a problem hiding this comment.
LGTM +1. Pending Green CI build.
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…(Zhihua Deng, reviewed by Sai Hemanth Gantasala)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…(Zhihua Deng, reviewed by Sai Hemanth Gantasala)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support both LDAP and Kerberos Auth in HS2
Why are the changes needed?
Does this PR introduce any user-facing change?
Yes. For Http mode, we must append the new auth method to the end of property hive.server2.authentication in order to be compatible with the old HS2 client.
How was this patch tested?
Unit tests