HIVE-27358: Add test cases for HIVE-22816 (result caching with views) #4337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HIVE-22816 allowed queries on views with transactional tables to be cached, but did not add any test cases.
ayushtkn
reviewed
May 19, 2023
| null sort order: z | ||
| sort order: + | ||
| Map-reduce partition columns: _col0 (type: string) | ||
| Statistics: Num rows: 501 Data size: 43587 Basic stats: COMPLETE Column stats: COMPLETE |
Member
There was a problem hiding this comment.
we have recently sees data size causing a lot of flakiness? if not necessary can we explore masking the size values?
kgyrtkirk
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
ayushtkn
approved these changes
May 21, 2023
Member
ayushtkn
left a comment
ayushtkn
left a comment
There was a problem hiding this comment.
LGTM
cam merge once we get a green build
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
|
Kudos, SonarCloud Quality Gate passed!
|
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…apache#4337). (John Sherman, Reviewed by Ayush Saxena, Attila Turoczy)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…apache#4337). (John Sherman, Reviewed by Ayush Saxena, Attila Turoczy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A couple of additional test cases.
Why are the changes needed?
To ensure that this feature continues to work in the future.
Does this PR introduce any user-facing change?
Nope
How was this patch tested?
Ran the added test.