Skip to content

Conversation

@abstractdog
Copy link
Contributor

@abstractdog abstractdog commented Jul 19, 2023

What changes were proposed in this pull request?

This change is about putting tez DAG scoped properties into DAG config while constructing the DAG,

Why are the changes needed?

Because without this patch, hive on tez user is unable to make tez options applied on dag level by simply doung set tez.x.y=z in beeline.

Does this PR introduce any user-facing change?

No.

Is the change a dependency upgrade?

No.

How was this patch tested?

Tested on cluster with TEZ-4344.

@abstractdog abstractdog force-pushed the HIVE-27516 branch 2 times, most recently from 1060674 to ec48479 Compare July 19, 2023 19:16
@abstractdog abstractdog changed the title Hive 27516 HIVE-27516: Add programatically added DAG scoped properties to DAG Configuration Jul 20, 2023
@abstractdog abstractdog requested a review from ayushtkn July 20, 2023 08:35
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the tests are green

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abstractdog abstractdog merged commit bfa16df into apache:master Jul 20, 2023
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
…nfiguration (apache#4503) (Laszlo Bodor reviewed by Ayush Saxena)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants