Skip to content

HIVE-27916: Increase tez.am.resource.memory.mb for TestIcebergCliDrver to 512MB #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged

HIVE-27916: Increase tez.am.resource.memory.mb for TestIcebergCliDrver to 512MB #4907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/conf/iceberg/tez/tez-site.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</property>
<property>
<name>tez.am.resource.memory.mb</name>
<value>256</value>
<value>512</value>
Copy link
Member

@deniskuzZ deniskuzZ Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if that is required, as there were no issues upstream so far, but it won't harm

Copy link
Member

@deniskuzZ deniskuzZ Nov 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, should we drop hive.tez.container.size from tez and llap tez-site.xml? the same thing is set in hive-site.xml but with a lower limit - 128 vs 512

Copy link
Contributor Author

@abstractdog abstractdog Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hive.tez.container.size is for task containers in particular (it's used to create the Resource object which is provided to yarn), whereas tez.am.resource.memory.mb is for the Application Master, so basically, it would make sense to review it in (only) case of llap drivers' config, as it's confusing: LLAP is not Tez container mode

regarding duplicated stuff in hive-site.xml and tez-site.xml...yeah, it's confusing too, let me check

regarding upstream failures: yeah, I cannot recall precommit issue in particular, however there were some in downstream, so as you said: it won't harm

</property>
<property>
<name>tez.runtime.io.sort.mb</name>
Expand Down