-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27918: Iceberg: Push transforms for clustering during table writes #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac18456 to
5e6d8c3
Compare
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just 1 comment
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
Outdated
Show resolved
Hide resolved
5e6d8c3 to
2c66112
Compare
457a99d to
139aba2
Compare
139aba2 to
ecbb54b
Compare
deniskuzZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, pending tests
|
Kudos, SonarCloud Quality Gate passed!
|
…es (apache#4908) (Sourabh Badhya reviewed by Denys Kuzmenko)
…es (apache#4908) (Sourabh Badhya reviewed by Denys Kuzmenko)
…es (apache#4908) (Sourabh Badhya reviewed by Denys Kuzmenko)










What changes were proposed in this pull request?
Iceberg: Push transforms for clustering during table writes
Why are the changes needed?
Currently transformed columns (except for bucket transform) are not pushed / passed as clustering columns. This can lead to incorrect clustering on such columns which can lead non-performant writes. Hence push transforms for clustering during table writes.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
QTests