HIVE-27988: Don't convert FullOuterJoin + filter to MapJoin #4958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le location. (apache#4910). (Ayush Saxena, reviewed by Denys Kuzmenko)
…data breach - handling default locations. (apache#4921). (Ayush Saxena, reviewed by Sourabh Badhya)
… (Wechar, reviewed by Ayush Saxena)
…m Sharma, reviewed by Ayush Saxena)
… reviewed by Denys Kuzmenko) Closes apache#4858
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
deniskuzZ
reviewed
Dec 20, 2023
ql/src/test/results/clientpositive/llap/mapjoin_filter_on_outerjoin_tez.q.out
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
deniskuzZ
force-pushed
the
branch-4.0
branch
2 times, most recently
from
570d0d2 to
92a4b29
Compare
deniskuzZ
changed the title
|
deniskuzZ
pushed a commit
to deniskuzZ/hive
that referenced
this pull request
Mar 1, 2024
…gon Namgung, reviewed by Denys Kuzmenko) Closes apache#4958 (cherry picked from commit f355c82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not convert FullOuter Join to MapJoin if it has filter expressions. This partially disables HIVE-18908 optimization, which introduces FullOuterJoin + MapJoin.
Why are the changes needed?
As described in HIVE-27226, current Hive produces wrong result when we have FullOuterJoin + MapJoin + filters.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
No test was added as this is just a quick-fix.
One can check the execution of FullOuterJoin + MapJoin + filter by running queries in HIVE-27226 JIRA pages.