-
Notifications
You must be signed in to change notification settings - Fork 67
test: construct temporal values from structural inputs #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <chrono> | ||
| #include <cstdint> | ||
|
|
||
| namespace iceberg { | ||
|
|
||
| using namespace std::chrono; // NOLINT | ||
|
|
||
| struct DateParts { | ||
| int32_t year{0}; | ||
| uint8_t month{0}; | ||
| uint8_t day{0}; | ||
| }; | ||
|
|
||
| struct TimeParts { | ||
| int32_t hour{0}; | ||
| int32_t minute{0}; | ||
| int32_t second{0}; | ||
| int32_t microsecond{0}; | ||
| }; | ||
|
|
||
| struct TimestampParts { | ||
| int32_t year{0}; | ||
| uint8_t month{0}; | ||
| uint8_t day{0}; | ||
| int32_t hour{0}; | ||
| int32_t minute{0}; | ||
| int32_t second{0}; | ||
| int32_t microsecond{0}; | ||
| // e.g. -480 for PST (UTC-8:00), +480 for Asia/Shanghai (UTC+8:00) | ||
| int32_t tz_offset_minutes{0}; | ||
| }; | ||
|
|
||
| struct TimestampNanosParts { | ||
| int32_t year{0}; | ||
| uint8_t month{0}; | ||
| uint8_t day{0}; | ||
| int32_t hour{0}; | ||
| int32_t minute{0}; | ||
| int32_t second{0}; | ||
| int32_t nanosecond{0}; | ||
| // e.g. -480 for PST (UTC-8:00), +480 for Asia/Shanghai (UTC+8:00) | ||
| int32_t tz_offset_minutes{0}; | ||
| }; | ||
|
|
||
| class TemporalTestHelper { | ||
| static constexpr auto kEpochDays = sys_days(year{1970} / January / 1); | ||
|
|
||
| public: | ||
| /// \brief Construct a Calendar date without timezone or time | ||
| static int32_t CreateDate(const DateParts& parts) { | ||
| return static_cast<int32_t>( | ||
| (sys_days(year{parts.year} / month{parts.month} / day{parts.day}) - kEpochDays) | ||
| .count()); | ||
| } | ||
|
|
||
| /// \brief Construct a time-of-day, microsecond precision, without date, timezone | ||
| static int64_t CreateTime(const TimeParts& parts) { | ||
| return duration_cast<microseconds>(hours(parts.hour) + minutes(parts.minute) + | ||
| seconds(parts.second) + | ||
| microseconds(parts.microsecond)) | ||
| .count(); | ||
| } | ||
|
|
||
| /// \brief Construct a timestamp, microsecond precision, without timezone | ||
| static int64_t CreateTimestamp(const TimestampParts& parts) { | ||
| year_month_day ymd{year{parts.year}, month{parts.month}, day{parts.day}}; | ||
| auto tp = sys_time<microseconds>{(sys_days(ymd) + hours{parts.hour} + | ||
| minutes{parts.minute} + seconds{parts.second} + | ||
| microseconds{parts.microsecond}) | ||
| .time_since_epoch()}; | ||
| return tp.time_since_epoch().count(); | ||
| } | ||
|
|
||
| /// \brief Construct a timestamp, microsecond precision, with timezone | ||
| static int64_t CreateTimestampTz(const TimestampParts& parts) { | ||
| year_month_day ymd{year{parts.year}, month{parts.month}, day{parts.day}}; | ||
| auto tp = sys_time<microseconds>{(sys_days(ymd) + hours{parts.hour} + | ||
| minutes{parts.minute} + seconds{parts.second} + | ||
| microseconds{parts.microsecond} - | ||
| minutes{parts.tz_offset_minutes}) | ||
| .time_since_epoch()}; | ||
| return tp.time_since_epoch().count(); | ||
| } | ||
|
|
||
| /// \brief Construct a timestamp, nanosecond precision, without timezone | ||
| static int64_t CreateTimestampNanos(const TimestampNanosParts& parts) { | ||
| year_month_day ymd{year{parts.year}, month{parts.month}, day{parts.day}}; | ||
| auto tp = | ||
| sys_time<nanoseconds>{(sys_days(ymd) + hours{parts.hour} + minutes{parts.minute} + | ||
| seconds{parts.second} + nanoseconds{parts.nanosecond}) | ||
| .time_since_epoch()}; | ||
| return tp.time_since_epoch().count(); | ||
| } | ||
|
|
||
| /// \brief Construct a timestamp, nanosecond precision, with timezone | ||
| static int64_t CreateTimestampTzNanos(const TimestampNanosParts& parts) { | ||
| year_month_day ymd{year{parts.year}, month{parts.month}, day{parts.day}}; | ||
| auto tp = | ||
| sys_time<nanoseconds>{(sys_days(ymd) + hours{parts.hour} + minutes{parts.minute} + | ||
| seconds{parts.second} + nanoseconds{parts.nanosecond} - | ||
| minutes{parts.tz_offset_minutes}) | ||
| .time_since_epoch()}; | ||
| return tp.time_since_epoch().count(); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace iceberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has already been added by the header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't been directly added by the temporal_util.h, there are uses of
int32_tin this file, so I think include the header is fine?