Skip to content

feat: add literal cast to date #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
+55 −4
Merged

feat: add literal cast to date #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0d2517
feat: add literal cast to date
zhjwpku Oct 21, 2025
13bce28
fix: add a timestamp before UNIX epoch
zhjwpku Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/iceberg/expression/literal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include "iceberg/util/checked_cast.h"
#include "iceberg/util/conversions.h"
#include "iceberg/util/macros.h"
#include "iceberg/util/temporal_util.h"

namespace iceberg {

Expand Down Expand Up @@ -209,8 +210,10 @@ Result<Literal> LiteralCaster::CastFromTimestamp(
auto timestamp_val = std::get<int64_t>(literal.value_);

switch (target_type->type_id()) {
case TypeId::kDate:
return NotImplemented("Cast from Timestamp to Date is not implemented yet");
case TypeId::kDate: {
ICEBERG_ASSIGN_OR_RAISE(auto days, TemporalUtils::ExtractDay(literal));
return Literal::Date(std::get<int32_t>(days.value()));
}
case TypeId::kTimestampTz:
return Literal::TimestampTz(timestamp_val);
default:
Expand All @@ -224,8 +227,10 @@ Result<Literal> LiteralCaster::CastFromTimestampTz(
auto micros = std::get<int64_t>(literal.value_);

switch (target_type->type_id()) {
case TypeId::kDate:
return NotImplemented("Cast from TimestampTz to Date is not implemented yet");
case TypeId::kDate: {
ICEBERG_ASSIGN_OR_RAISE(auto days, TemporalUtils::ExtractDay(literal));
return Literal::Date(std::get<int32_t>(days.value()));
}
case TypeId::kTimestamp:
return Literal::Timestamp(micros);
default:
Expand Down
46 changes: 46 additions & 0 deletions src/iceberg/test/literal_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include "iceberg/type.h"
#include "matchers.h"
#include "temporal_test_helper.h"

namespace iceberg {

Expand Down Expand Up @@ -689,6 +690,51 @@ INSTANTIATE_TEST_SUITE_P(
.source_literal = Literal::Long(42L),
.target_type = timestamp_tz(),
.expected_literal = Literal::TimestampTz(42L)},
CastLiteralTestParam{
.test_name = "TimestampToDate",
.source_literal =
Literal::Timestamp(TemporalTestHelper::CreateTimestamp({.year = 2021,
.month = 6,
.day = 1,
.hour = 11,
.minute = 43,
.second = 20})),
.target_type = date(),
.expected_literal = Literal::Date(
TemporalTestHelper::CreateDate({.year = 2021, .month = 6, .day = 1}))},
CastLiteralTestParam{
.test_name = "TimestampTzToDate",
.source_literal = Literal::TimestampTz(
TemporalTestHelper::CreateTimestampTz({.year = 2021,
.month = 1,
.day = 1,
.hour = 7,
.minute = 43,
.second = 20,
.tz_offset_minutes = 480})),
.target_type = date(),
.expected_literal = Literal::Date(
TemporalTestHelper::CreateDate({.year = 2020, .month = 12, .day = 31}))},
CastLiteralTestParam{.test_name = "EpochToDate",
.source_literal = Literal::Timestamp(
TemporalTestHelper::CreateTimestamp({.year = 1970,
.month = 1,
.day = 1,
.hour = 0,
.minute = 0,
.second = 0})),
.target_type = date(),
.expected_literal = Literal::Date(0)},
CastLiteralTestParam{.test_name = "TimestampBeforeEpochToDate",
.source_literal = Literal::Timestamp(
TemporalTestHelper::CreateTimestamp({.year = 1969,
.month = 12,
.day = 31,
.hour = 23,
.minute = 59,
.second = 59})),
.target_type = date(),
.expected_literal = Literal::Date(-1)},
// Float cast tests
CastLiteralTestParam{.test_name = "FloatToDouble",
.source_literal = Literal::Float(2.0f),
Expand Down
Loading