feat: Add validation for AssertCurrentSchemaID #286
Merged
+51
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwpku
approved these changes
Nov 2, 2025
Collaborator
zhjwpku
left a comment
zhjwpku
left a comment
There was a problem hiding this comment.
LGTM except for one small nit about the comment.
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
wgtmac
approved these changes
Nov 3, 2025
gty404
approved these changes
Nov 3, 2025
wgtmac
changed the title
Member
|
Thanks @shangxinli for working on it and @zhjwpku @gty404 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix table_requirement by implementing AssertCurrentSchemaID::Validate()
This PR implements the missing
AssertCurrentSchemaID::Validate()method intable_requirement.cc, enabling proper validation of schema ID requirements for optimistic concurrency control in table operations.This is my first contribution to iceberg-cpp. I plan to implement the remaining validation methods in next PRs.