test: add manifest list test cases #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
changed the title
Member
Author
There was a problem hiding this comment.
Pull Request Overview
This PR refactors manifest and manifest list schema initialization across different Iceberg format versions (V1, V2, V3). The changes replace dynamic schema construction based on field ID sets with static, version-specific schema definitions, improving code clarity and maintainability.
Key changes:
- Introduced static helper methods (
EntrySchema,WrapFileSchema,FileType/DataFileSchema) for constructing version-specific schemas - Added static
kManifestListSchemaconstants for each format version - Changed V3's
first_row_idparameter fromstd::optional<int64_t>toint64_tin writer constructors - Removed
InitSchemamethods from base adapter classes - Updated error message format strings from
%sto{}for consistency withstd::format
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/iceberg/v1_metadata.h/cc | Added static schema construction methods and manifest list schema constant for V1 |
| src/iceberg/v2_metadata.h/cc | Added static schema construction methods and manifest list schema constant for V2 |
| src/iceberg/v3_metadata.h/cc | Added static schema construction methods, manifest list schema constant, changed first_row_id to non-optional, renamed method to WrapFirstRowId |
| src/iceberg/schema_field.h | Added AsRequired/AsOptional helper methods for field optionality conversion |
| src/iceberg/manifest_writer.h/cc | Changed MakeV3Writer signature to accept non-optional first_row_id, added next_row_id() accessor |
| src/iceberg/manifest_adapter.h/cc | Removed InitSchema methods, moved partition_spec initialization to constructor, added next_row_id() virtual method |
| src/iceberg/manifest_list.h/cc | Changed Type() return type from StructType reference to shared_ptr |
| src/iceberg/manifest_entry.h/cc | Added partition documentation constant, updated default partition type handling |
| src/iceberg/manifest_reader.cc | Simplified manifest list reader initialization using new Type() signature |
| src/iceberg/test/manifest_list_versions_test.cc | New comprehensive test file for cross-version manifest list compatibility |
| src/iceberg/test/CMakeLists.txt | Added new test file to build configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- fix schema definition of manifest list & file with versions - port manifest list test cases from java - fix various issues found by new cases - support manifest writer to write data and delete content
zhjwpku
reviewed
Nov 8, 2025
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
liurenjie1024
approved these changes
Nov 10, 2025
Member
Author
|
Thanks @zhjwpku and @liurenjie1024 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.