refactor: trivial improvements and minor fixes #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
approved these changes
Nov 11, 2025
|
|
||
| return std::make_unique<SortOrder>(sort_id, std::move(fields)); | ||
| auto sort_order = std::make_unique<SortOrder>(sort_id, std::move(fields)); | ||
| ICEBERG_RETURN_UNEXPECTED(sort_order->Validate(schema)); |
Collaborator
There was a problem hiding this comment.
LGTM, this is more precise.
HeartLinked
force-pushed
the
fix/some
branch
from
b20f653 to
90a3bc5
Compare
Fokko
approved these changes
Nov 11, 2025
zhjwpku
approved these changes
Nov 11, 2025
|
|
||
| return std::make_unique<SortOrder>(sort_id, std::move(fields)); | ||
| auto sort_order = std::make_unique<SortOrder>(sort_id, std::move(fields)); | ||
| ICEBERG_RETURN_UNEXPECTED(sort_order->Validate(schema)); |
Collaborator
There was a problem hiding this comment.
LGTM, this is more precise.
Member
|
Let me merge this. Thanks @HeartLinked @zhjwpku and @Fokko! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.