Skip to content

Conversation

rambleraptor
Copy link
Contributor

Closes #2559

Rationale for this change

This adds the same Matomo script tag found in the Iceberg website to our Python documentation website.

Are these changes tested?

Screenshot 2025-10-06 at 3 53 49 PM

Script tag found when served locally.

Are there any user-facing changes?

@kevinjqliu
Copy link
Contributor

Thanks @rambleraptor looks like we need the asf header for the new file

@rambleraptor
Copy link
Contributor Author

Is it possible for us to turn off the copyright checker on that one file?

It seems like a waste for every rendered HTML to include the ASF header just to fulfill this requirement.

@kevinjqliu
Copy link
Contributor

yea i noticed the file in the other repo doesnt need the ASF header https://github.com/apache/iceberg/blob/main/site/overrides/main.html

we can modify https://github.com/apache/iceberg-python/blob/main/dev/.rat-excludes

i think its fine to exclude all of mkdocs/ since its not included in the build artifacts

packages = [
{ include = "pyiceberg" },
{ from = "vendor", include = "fb303" },
{ from = "vendor", include = "hive_metastore" },
{ include = "tests", format = "sdist" },
{ include = "Makefile", format = "sdist" },
{ include = "NOTICE", format = [
"sdist",
"wheel",
] },
]
include = [
{ path = "dev", format = "sdist" },
{ path = "pyiceberg/**/*.so", format = "wheel" },
{ path = "pyiceberg/**/*.pyd", format = "wheel" },
{ path = "poetry.lock", format = "sdist" },
]

@Fokko what do you think?

@rambleraptor
Copy link
Contributor Author

@kevinjqliu @Fokko added mkdocs/ to .rat-excludes!

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this @rambleraptor 🙌 Thanks for the review @kevinjqliu

@Fokko Fokko merged commit 3a9eab3 into apache:main Oct 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add web analytics to https://py.iceberg.apache.org/

3 participants