table.inspect.partitions(): add filter expression #2596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to filter partitions using expressions when inspecting table partitions, similar to scan planning.
emilie-wang
commented
Oct 9, 2025
pyiceberg/table/__init__.py
Outdated
|
|
||
| def plan_files(self) -> Iterable[FileScanTask]: | ||
| """Plans the relevant files by filtering on the PartitionSpecs. | ||
| def scan_plan_helper(self) -> Iterator[ManifestEntry]: |
There was a problem hiding this comment.
I refactored this part so that it can be reused in inspect.partitions(), but not sure if it is the best way.
could you please let me know your thoughts @Fokko? Thanks! And the name is terrible and I could rework on it.
|
Hi @Fokko sorry to ping you and I did a few updates after the initial commit and would like to have your feedbacks. Thanks a lot! |
Fokko
approved these changes
Oct 17, 2025
There was a problem hiding this comment.
@emilie-wang Sorry for the late reply, this looks great to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 2562
Rationale for this change
Allow users to query specific partitions with predicate while inspecting table partitions.
As suggested, add a predicate as an argument into
table.inspect.partitions()that defaults to ALWAYS_TRUE.Are these changes tested?
Yes, new integration tests added.
Are there any user-facing changes?
I believe no.