Skip to content

Conversation

@kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Nov 5, 2025

Rationale for this change

Removes ignoring ruff rule (B905 zip-without-explicit-strict)
Use strict=True in all zip instances

Relates to #2700
Follow up to #2696

Are these changes tested?

Yes, existing test suite

Are there any user-facing changes?

No

@kevinjqliu kevinjqliu changed the title Kevinjqliu/ruff b905 lint: remove ignoring ruff rule B905 Nov 5, 2025
@kevinjqliu kevinjqliu changed the title lint: remove ignoring ruff rule B905 lint: remove ignoring ruff rule B905 (zip-without-explicit-strict) Nov 5, 2025
@kevinjqliu kevinjqliu requested a review from Fokko November 5, 2025 14:52
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @kevinjqliu 🙌

@kevinjqliu kevinjqliu merged commit f7c6753 into apache:main Nov 6, 2025
8 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/ruff-B905 branch November 6, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants