Skip to content

Conversation

@ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Nov 29, 2025

Rationale for this change

Iceberg spec expects iceberg.required attribute in addition to iceberg.id:

The column IDs must be stored in ORC type attributes using the key iceberg.id, and iceberg.required to store "true" if the Iceberg column is required, otherwise it will be optional.

https://iceberg.apache.org/spec/#orc

Fixes #2526

Are these changes tested?

Yes

Are there any user-facing changes?

@ebyhr ebyhr force-pushed the ebi/orc-required branch 2 times, most recently from 90e45df to 8449f7f Compare November 29, 2025 09:14
Copy link
Contributor

@geruh geruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ebyhr, this is great! Just have the tiny comment below.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks @ebyhr for picking this up, and thanks @geruh for the review 🙌

@Fokko Fokko merged commit 33438bd into apache:main Dec 1, 2025
8 checks passed
@ebyhr ebyhr deleted the ebi/orc-required branch December 1, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set iceberg.required field attribute for ORC

3 participants