Skip to content

Conversation

@mbutrovich
Copy link
Collaborator

Which issue does this PR close?

What changes are included in this PR?

Split up values.rs into component files in a values folder. Happy to discuss organization. Here are the details to account for line differences:

  1. Copyright headers duplicated - Each of the new files got its own Apache license header
  2. Module structure added - Created mod.rs with module declarations and re-exports
  3. Module-level docs added - Changed from /*! Value in iceberg */ to individual //! style doc comments for each
    module
  4. Visibility changes - Changed 5 constants from private const to pub(crate) const. This was necessary so these constants could be accessed across the split files:
    • MAX_TIME_VALUE
    • INT_MAX
    • INT_MIN
    • LONG_MAX
    • LONG_MIN

Are these changes tested?

Existing tests.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbutrovich for this fix! I didn't expect it has grown to so large.

@liurenjie1024 liurenjie1024 merged commit 776701c into apache:main Nov 12, 2025
18 checks passed
@mbutrovich mbutrovich deleted the split_values branch November 12, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split iceberg/src/spec/values.rs into multiple files

2 participants