Skip to content

KafkaConnect: Fix Nested schema evolution #15396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annurahar wants to merge 3 commits into
base: main
Choose a base branch
from
Open

KafkaConnect: Fix Nested schema evolution #15396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4716435
Kafka Connect: Fix nested schema evolution
annurahar Feb 21, 2026
cafd683
Kafka Connect: Fix nested schema evolution
annurahar Feb 21, 2026
2e8155d
fix build error
annurahar Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 33 additions & 11 deletions kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.kafka.connect.errors.DataException;
import org.apache.kafka.connect.sink.SinkRecord;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

class IcebergWriter implements RecordWriter {
private static final Logger LOG = LoggerFactory.getLogger(IcebergWriter.class);
private final Table table;
private final TableReference tableReference;
private final IcebergSinkConfig config;
Expand Down Expand Up @@ -77,24 +80,43 @@ public void write(SinkRecord record) {

private Record convertToRow(SinkRecord record) {
if (!config.evolveSchemaEnabled()) {
return recordConverter.convert(record.value());
return recordConverter.convert(record);
}

SchemaUpdate.Consumer updates = new SchemaUpdate.Consumer();
Record row = recordConverter.convert(record.value(), updates);
recordConverter.evolveSchema(record, updates);

if (!updates.empty()) {
// complete the current file
flush();
// apply the schema updates, this will refresh the table
SchemaUtils.applySchemaUpdates(table, updates);
// initialize a new writer with the new schema
initNewWriter();
// convert the row again, this time using the new table schema
row = recordConverter.convert(record.value(), null);
try {
// complete the current file
flush();

// apply the schema updates, this will refresh the table
SchemaUtils.applySchemaUpdates(table, updates);
LOG.info(
"Schema evolution on table {} caused by record at topic: {}, partition: {}, offset: {}",
table.name(),
record.topic(),
record.kafkaPartition(),
record.kafkaOffset());
} catch (Exception e) {
LOG.error(
"Schema updates for table {} not applied by record at topic: {}, partition: {}, offset: {} because {}. Data will still be written to table",
table.name(),
record.topic(),
record.kafkaPartition(),
record.kafkaOffset(),
e.getMessage(),
e);
} finally {
// initialize a new writer with the latest schema - in case any other task has already
// applied the schema updates
initNewWriter();
}
}

return row;
// convert the row, this time new table schema will be used
return recordConverter.convert(record);
}

private void flush() {
Expand Down
Loading