[BEAM-806] update archetype poms in master#1169
Conversation
Per the linked JIRA, maven release:branch did not do the right thing.
|
LGTM. Do we know why? I don't remember doing this myself. |
|
From Luke:
This is completely true, and the process of fixing it manually in master works. But this does not help the release process, which is specifically designed to use |
|
LGTM for master but it doesn't solve my problem with the On a side note, it's somewhat strange that the release plugin pushes everything to git right-away without giving me a chance to correct things. (I know that this is documented in the release guide and I knew it when executing the command, but still...) |
|
Totally agree that automatic pushes are not a great idea. There's a manual flag to disable them. It would be great if all this went through pull requests, but that appears to be non-standard. I'm hopeful we can improve this in the near future. |
|
At the same time, manual fixup of PRs is not reproducible across different committers or releases... a platonic release process would be fully automated. We ought to fix the process such that even if done in PRs we are not needing to do anything but rubber stamp; and we would catch breakages to the release process earlier. Maybe we can do some of this with the nightlies, like testing that we can run mvn release:prepare and that it compiles? |
Per the linked JIRA, maven release:branch did not do the right thing.
R: @aljoscha
CC: @davorbonaci