[BEAM-823, BEAM-923] Add localhost option for DatastoreIO#1293
[BEAM-823, BEAM-923] Add localhost option for DatastoreIO#1293vikkyrk wants to merge 4 commits intoapache:masterfrom vikkyrk:ds_doc
Conversation
|
R: @dhalperi |
vikkyrk
changed the title
|
R: @davorbonaci since Dan is busy. |
| * all returned results will be read by a single Dataflow worker in order to ensure correct data. | ||
| * {@link com.google.datastore.v1.Query.Builder#setLimit(Int32Value)} or if the Query contains | ||
| * inequality filters like {@code GREATER_THAN, LESS_THAN} etc., then all returned results | ||
| * will be read by a single Dataflow worker in order to ensure correct data. Since data is read from |
There was a problem hiding this comment.
Please abstract Dataflow away.
| abstract Builder setQuery(Query query); | ||
| abstract Builder setNamespace(String namespace); | ||
| abstract Builder setNumQuerySplits(int numQuerySplits); | ||
| abstract Builder setLocalhost(String hostPort); |
There was a problem hiding this comment.
I would have used 'InetAddress' but to keep it in sync with the DatastoreOptions which uses a String, I kept it consistent.
| .build(); | ||
| } | ||
|
|
||
| public DatastoreV1.Read withLocalhost(String localhost) { |
There was a problem hiding this comment.
I'm not sure what localhost parameter here means.
|
Thanks @davorbonaci ; R: -@dhalperi |
|
R: @davorbonaci addressed comments. |
|
This needs to be rebased after template is merged #1369 |
|
Refer to this link for build results (access rights to CI server needed): |
|
Status? |
|
This might have merge conflict with #1369, so planning to serialize them. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Kicked off postcommit: https://builds.apache.org/view/Beam/job/beam_PostCommit_Java_MavenInstall/2522/org.apache.beam$beam-sdks-java-io-google-cloud-platform/testReport/ and it passed (the GCP-IO ITs ran and passed, at least). So merging. Thanks! |
4 participants
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.