Skip to content

[BEAM-44] Stop nesting Nullable coders#136

Closed
tgroh wants to merge 1 commit intoapache:masterfrom
tgroh:nullable_coder
Closed

[BEAM-44] Stop nesting Nullable coders#136
tgroh wants to merge 1 commit intoapache:masterfrom
tgroh:nullable_coder

Conversation

@tgroh
Copy link
Member

@tgroh tgroh commented Apr 6, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace "<Jira issue #>" in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

A single layer of nullable coders is sufficient to safely encode
possibly-null values. This allows use of NullableCoder#of to wrap any
coder, without duplicating null-safety logic applied by NullableCoder.

Fixes BEAM-44

@tgroh
Copy link
Member Author

tgroh commented Apr 6, 2016

R: @dhalperi

A single layer of nullable coders is sufficient to safely encode
possibly-null values. This allows use of NullableCoder#of to wrap any
coder, without duplicating null-safety logic applied by NullableCoder.

This change is not update compatible.

Fixes BEAM-44
@davorbonaci
Copy link
Member

I'll take this. LGTM. Merge in progress.

@davorbonaci
Copy link
Member

R: @davorbonaci

@asfgit asfgit closed this in e3f2d95 Apr 6, 2016
tgroh pushed a commit to tgroh/beam that referenced this pull request Apr 7, 2016
iemejia referenced this pull request in iemejia/beam Jan 12, 2018
minxhe pushed a commit to minxhe/beam that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants