Skip to content

Add fields retry#1396

Closed
sb2nov wants to merge 2 commits intoapache:python-sdkfrom
sb2nov:BEAM-add-fields-retry
Closed

Add fields retry#1396
sb2nov wants to merge 2 commits intoapache:python-sdkfrom
sb2nov:BEAM-add-fields-retry

Conversation

@sb2nov
Copy link
Contributor

@sb2nov sb2nov commented Nov 21, 2016

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

Allow changing all the fields from FuzzedExponentialIntervals in the retry decorator

R: @chamikaramj PTAL

@asfbot
Copy link

asfbot commented Nov 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_Build/28/
--none--

@sb2nov sb2nov force-pushed the BEAM-add-fields-retry branch from 68dc37b to 268b803 Compare November 21, 2016 19:40
@asfbot
Copy link

asfbot commented Nov 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_Build/29/
--none--

num_retries=16, initial_delay_secs=5.0, logger=logging.warning,
retry_filter=retry_on_server_errors_filter,
clock=Clock(), fuzz=True):
clock=Clock(), fuzz=True, factor=2, max_delay_secs=60 * 60 * 4):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain these in Args.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sb2nov
Copy link
Contributor Author

sb2nov commented Nov 21, 2016

R: @chamikaramj PTAL

@chamikaramj
Copy link
Contributor

LGTM

@asfbot
Copy link

asfbot commented Nov 21, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Java_Build/35/
--none--

@sb2nov
Copy link
Contributor Author

sb2nov commented Nov 21, 2016

@davorbonaci Please merge

@davorbonaci
Copy link
Member

Done.

asfgit pushed a commit that referenced this pull request Nov 21, 2016
@sb2nov
Copy link
Contributor Author

sb2nov commented Nov 21, 2016

Thanks

@sb2nov sb2nov closed this Nov 21, 2016
@sb2nov sb2nov deleted the BEAM-add-fields-retry branch November 21, 2016 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants