[BEAM-1065] FileBasedSource: replace SeekableByteChannel with open(spec, startingPosition).#1426
Closed
peihe wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-1065] FileBasedSource: replace SeekableByteChannel with open(spec, startingPosition).#1426peihe wants to merge 1 commit intoapache:masterfrom
peihe wants to merge 1 commit intoapache:masterfrom
Conversation
peihe
force-pushed
the
io-channel-open-channel
branch
from
714a813 to
25e4834
Compare
peihe
changed the title
peihe
force-pushed
the
io-channel-open-channel
branch
from
25e4834 to
8e8a4c9
Compare
Contributor
Author
|
R: @dhalperi |
peihe
force-pushed
the
io-channel-open-channel
branch
from
8e8a4c9 to
2354183
Compare
peihe
force-pushed
the
io-channel-open-channel
branch
from
2354183 to
9131cdb
Compare
peihe
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
Contributor
|
Please see feedback on https://issues.apache.org/jira/browse/BEAM-1065. In short, I think that the change to let source implementations specify their starting offset is awesome. But it's probably worth it's own separate PR. As for dropping seekability, for reasons in the JIRA I think seekability is very useful and should stay. |
Contributor
Author
|
closing, will address this in IOChannelFactory redesign. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.