Move allowsDynamicSplitting to Reader, and set it in CompressedSource.#502
Closed
peihe wants to merge 2 commits intoapache:masterfrom
Closed
Move allowsDynamicSplitting to Reader, and set it in CompressedSource.#502peihe wants to merge 2 commits intoapache:masterfrom
peihe wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
R: @dhalperi |
| // checkpoint every 9 elements | ||
| if (actual.size() % 9 == 0) { | ||
| Double fractionConsumed = reader.getFractionConsumed(); | ||
| if (fractionConsumed != null) { |
Contributor
There was a problem hiding this comment.
when can fractionConsumed be null? This test might fail for a variety of reasons.
Contributor
There was a problem hiding this comment.
or rather, might silently pass. E.g., if fractionConsumed is always null.
Contributor
|
LGTM, will merge once green. |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
~~Based on branch for PR apache#500 -- I will rebase after that PR merges.~~ Closes apache#367. Supersedes PR apache#497.
Amar3tto
added a commit
to akvelon/beam
that referenced
this pull request
Mar 4, 2025
Add refresh looker .yml workflow and .py script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change in CompressedSource, testUnsplittable() fails in:
assertNull(reader.splitAtFraction(fractionConsumed));