[BEAM-408] - Fixes ProxyInvocationHandler uses inefficient Math.random() for random int#588
Closed
lucasamorimca wants to merge 3 commits intoapache:masterfrom
Closed
[BEAM-408] - Fixes ProxyInvocationHandler uses inefficient Math.random() for random int#588lucasamorimca wants to merge 3 commits intoapache:masterfrom
lucasamorimca wants to merge 3 commits intoapache:masterfrom
Conversation
…m() for random int For more information: https://issues.apache.org/jira/browse/BEAM-408
| * between 0 and {@link Integer#MAX_VALUE}. | ||
| */ | ||
| private final int hashCode = (int) (Math.random() * Integer.MAX_VALUE); | ||
| private final int hashCode = (RANDOM.nextInt() * Integer.MAX_VALUE); |
Member
There was a problem hiding this comment.
Please swap to use ThreadLocalRandom.current().nextInt(Integer.MIN_VALUE, Integer.MAX_VALUE) instead of the static RANDOM
https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadLocalRandom.html
Member
|
R: @lukecwik |
| * between 0 and {@link Integer#MAX_VALUE}. | ||
| */ | ||
| private final int hashCode = (int) (Math.random() * Integer.MAX_VALUE); | ||
| private final int hashCode = ThreadLocalRandom.current().nextInt( |
| * between 0 and {@link Integer#MAX_VALUE}. | ||
| */ | ||
| private final int hashCode = (int) (Math.random() * Integer.MAX_VALUE); | ||
| private final int hashCode = ThreadLocalRandom.current().nextInt( |
Member
There was a problem hiding this comment.
It turns out you ran into an undocumented limit of nextInt, it can't generate such a large range since it overflows internally (when subtracting min from max):
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/7u40-b43/java/util/concurrent/ThreadLocalRandom.java?av=f#143
I'll merge and update to use nextInt()
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more information: https://issues.apache.org/jira/browse/BEAM-408