Skip to content

Pickle only used symbols from __main__ namespace.#629

Closed
robertwb wants to merge 1 commit intoapache:python-sdkfrom
robertwb:pickling
Closed

Pickle only used symbols from __main__ namespace.#629
robertwb wants to merge 1 commit intoapache:python-sdkfrom
robertwb:pickling

Conversation

@robertwb
Copy link
Contributor

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

  • Make sure the PR title is formatted like:
    [BEAM-<Jira issue #>] Description of pull request
  • Make sure tests pass via mvn clean verify. (Even better, enable
    Travis-CI on your fork and ensure the whole test matrix passes).
  • Replace <Jira issue #> in the title with the actual Jira issue
    number, if there is one.
  • If this contribution is large, please file an Apache
    Individual Contributor License Agreement.

@robertwb
Copy link
Contributor Author

R: @silviulica

In particular, this means we can safely disable main session saving nearly everywhere.

@silviulica
Copy link
Contributor

LGTM and awesome! LEt's get this in and I will get the optional save_main_session right away out.

@robertwb
Copy link
Contributor Author

Thanks. Lucky for us, the "recursive" option was already part of dill (not that we wanted to use it everywhere of course).

asfgit pushed a commit that referenced this pull request Jul 11, 2016
@robertwb robertwb closed this Jul 11, 2016
asfgit pushed a commit that referenced this pull request Jul 12, 2016
Amar3tto added a commit to akvelon/beam that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants