Allow custom timestamp/watermark function for UnboundedFlinkSource#630
Closed
daviddesberg wants to merge 2 commits intoapache:masterfrom
Closed
Allow custom timestamp/watermark function for UnboundedFlinkSource#630daviddesberg wants to merge 2 commits intoapache:masterfrom
daviddesberg wants to merge 2 commits intoapache:masterfrom
Conversation
added 2 commits
July 11, 2016 12:24
Contributor
Contributor
|
LGTM! If no one objects I'll merge it later today. |
Author
|
@aljoscha awesome, thanks :) |
Contributor
|
Thanks! |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
…[autoapprove] (apache#630) Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced May 18, 2024
Amar3tto
added a commit
to akvelon/beam
that referenced
this pull request
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, using an
UnboundedFlinkSourceseems to force the timestamp applied to each element of the incoming stream to the ingestion time, rather than allowing for proper event timestamping. This PR adds the ability to created anUnboundedFlinkSourcewith a custom TimestampAssigner, which should alleviate that issue. Note that this is particularly useful, as currently the only means of consuming from Kafka 0.8 using Beam/Flink Runner is to wrap Flink's Kafka 0.8 consumer.