[BEAM-439] Remove optional args from start/finish bundle methods#668
Closed
silviulica wants to merge 1 commit intoapache:python-sdkfrom
Closed
[BEAM-439] Remove optional args from start/finish bundle methods#668silviulica wants to merge 1 commit intoapache:python-sdkfrom
silviulica wants to merge 1 commit intoapache:python-sdkfrom
Conversation
Contributor
|
LGTM now |
Contributor
|
Merged; please manually close PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@robertwb can you please take a look?
(take II -- I abandoned previous PR due to bad merge on my part)
Technically we do not want to allow deferred side inputs but it is much simple conceptually to remove
extra arguments altogether.