Skip to content

Fix SDK name and version sent to the Cloud Dataflow service#730

Merged
asfgit merged 2 commits intoapache:python-sdkfrom
charlesccychen:fix-sdk-version
Jul 26, 2016
Merged

Fix SDK name and version sent to the Cloud Dataflow service#730
asfgit merged 2 commits intoapache:python-sdkfrom
charlesccychen:fix-sdk-version

Conversation

@charlesccychen
Copy link
Copy Markdown
Contributor

No description provided.

@charlesccychen
Copy link
Copy Markdown
Contributor Author

R: @aaltay



def get_sdk_name_and_version():
"""Returns the name and version of the SDK reported to Cloud Dataflow."""
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Google Cloud Dataflow"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 26, 2016

LGTM, thank you.

@charlesccychen
Copy link
Copy Markdown
Contributor Author

Thanks!

@aaltay
Copy link
Copy Markdown
Member

aaltay commented Jul 26, 2016

R: @robertwb

@asfgit asfgit merged commit 76f3864 into apache:python-sdk Jul 26, 2016
asfgit pushed a commit that referenced this pull request Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants