Skip to content

Fix CheckHealth not set has_request_code#1502

Merged
wwbmmm merged 1 commit intoapache:masterfrom
serverglen:FixCheckHealth
Feb 25, 2022
Merged

Fix CheckHealth not set has_request_code#1502
wwbmmm merged 1 commit intoapache:masterfrom
serverglen:FixCheckHealth

Conversation

@serverglen
Copy link
Contributor

@serverglen serverglen commented Jul 29, 2021

loadbalancer:c_murmurhash
当某个下游实例由于某些原因被SetFailed之后,后台会启动一个健康检查线程定时(间隔由参数-health_check_interval控制)检查被屏蔽的实例是否恢复正常。
对于hash类型的loadbalancer,SelectServer(const SelectIn& in, SelectOut* out)函数中的in.has_request_code必须是true,否则会输出错误日志并返回错误(EINVAL)

if (!in.has_request_code) {
        LOG(ERROR) << "Controller.set_request_code() is required";
        return EINVAL;
}

如果下游实例只有几个,在某些情况下,有可能这些实例都被SetFailed了,从而导致后续的所有的请求都会失败。

@wwbmmm wwbmmm merged commit 89ed969 into apache:master Feb 25, 2022
@serverglen serverglen deleted the FixCheckHealth branch February 25, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants