change HLL public API from CamelCase to lower_with_underscore#52
Merged
AlexanderSaydakov merged 3 commits intomasterfrom Aug 8, 2019
Merged
change HLL public API from CamelCase to lower_with_underscore#52AlexanderSaydakov merged 3 commits intomasterfrom
AlexanderSaydakov merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
Actually, let's hold off on this a bit longer. I think I can do more fairly quickly. |
…and not forcing 'current' into the enum name
Contributor
Author
|
Now I think this is ready for review. Renaming HllSketchImpl will take more work with less obvious short-term benefit. |
Contributor
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I got the public portions of hll.hpp changed. This can be extended to that whole file if we think it's warranted.