Merged
Conversation
imay
requested changes
May 28, 2019
Contributor
imay
left a comment
imay
left a comment
There was a problem hiding this comment.
Add some unit test for this bug?
| return new IntLiteral(datediff, Type.INT); | ||
| String[] parsePatterns = { "yyyyMMdd" }; | ||
| try { | ||
| //DATEDIFF function only uses the date part for calculations and ignores the time part |
Contributor
There was a problem hiding this comment.
Suggested change
| //DATEDIFF function only uses the date part for calculations and ignores the time part | |
| // DATEDIFF function only uses the date part for calculations and ignores the time part |
imay
approved these changes
May 28, 2019
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
…ion (apache#1208) Co-authored-by: airborne12 <airborne12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the datediff function to compatible with MySQL function logic
The DATEDIFF function only uses the date part for calculations and ignores the time part