Skip to content

Conversation

@kangpinghuang
Copy link
Contributor

fix segment size calculation. Issue #2548

std::vector<Slice> origin_data;
origin_data.push_back(dict_page.slice());
RETURN_IF_ERROR(_write_physical_page(&origin_data, &_dict_page_pp));
RETURN_IF_ERROR(_write_slices(&origin_data));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss page pointer?

huangkangping and others added 2 commits December 25, 2019 20:25
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit ee64ab5 into apache:master Dec 26, 2019
infearOnTheWay pushed a commit to infearOnTheWay/incubator-doris that referenced this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants