[Load] Add more info in SHOW LOAD result#3391
Merged
morningman merged 3 commits intoapache:masterfrom Apr 26, 2020
Merged
Conversation
wutiangan
reviewed
Apr 25, 2020
| } | ||
|
|
||
| public synchronized void updateLoad(TUniqueId loadId, TUniqueId fragmentId, long rows) { | ||
| public synchronized void updateLoadProgress(long beId, TUniqueId loadId, TUniqueId fragmentId, long rows, |
Contributor
There was a problem hiding this comment.
Maybe change “beId” to ”backendId“ is better，at before you use unfinished“BackendIds” and all”BackendIds“
wutiangan
reviewed
Apr 25, 2020
| public synchronized void clearAllLoads() { | ||
| counterTbl.clear(); | ||
| if (isDone && unfinishedBackendIds.containsKey(loadId)) { | ||
| unfinishedBackendIds.get(loadId).remove(beId); |
Contributor
There was a problem hiding this comment.
can unfinishedBackendIds.get(loadId) be empty？
Contributor
Author
There was a problem hiding this comment.
It won't, there is at least one BE for a load job
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Apr 28, 2020
Fix apache#3390 This CL add more info in `JobDetails` column of `SHOW LOAD` result for Broker Load Job. For example: ``` { "Unfinished backends": { "9c3441027ff948a0-8287923329a2b6a7": [10002] }, "All backends": { "9c3441027ff948a0-8287923329a2b6a7": [10002, 10004, 10006] }, "ScannedRows": 2390016, "TaskNumber": 1, "FileNumber": 1, "FileSize": 1073741824 } ``` 2 newly added keys: `Unfinished backends` indicates the BE which task on them are not finished. `All backends` indicates the BE which this job has tasks on it. One more thing, I pass the Backend Id along with the heartbeat msg from FE to BE, so that BE can know the Id of themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3390
This CL add more info in
JobDetailscolumn ofSHOW LOADresult for Broker Load Job.For example:
2 newly added keys:
Unfinished backendsindicates the BE which task on them are not finished.All backendsindicates the BE which this job has tasks on it.One more thing, I pass the Backend Id along with the heartbeat msg from FE to BE, so that BE can
know the Id of themselves.