add version message to fe heartbeat and system page#4521
Merged
morningman merged 1 commit intoapache:branch-0.12from Sep 8, 2020
ccoffline:branch-0.12-fe-version
Merged
add version message to fe heartbeat and system page#4521morningman merged 1 commit intoapache:branch-0.12from ccoffline:branch-0.12-fe-version
morningman merged 1 commit intoapache:branch-0.12from
ccoffline:branch-0.12-fe-version
Conversation
Contributor
|
@ccoffline Hi, Thanks for your contribution.
If we only want to show a git commit message on FE web, why do we need to add a commit message to the heartbeat? |
Contributor
Author
FE web shows status of each BE and FE by represent the message from the heartbeat. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit adds git commit message of fe to the system page, just like be.
To achieve this, fe heartbeat message has now been carrying git commit message.
Types of changes
Checklist
Further comments
This is my first public pr so plzzzzzz be gentle, thx=.=