Skip to content

[BUG] Fixed the problem that substring function may access illegal ad…#5952

Merged
morningman merged 1 commit intoapache:masterfrom
stdpain:fix_string_func
Jun 3, 2021
Merged

[BUG] Fixed the problem that substring function may access illegal ad…#5952
morningman merged 1 commit intoapache:masterfrom
stdpain:fix_string_func

Conversation

@stdpain
Copy link
Contributor

@stdpain stdpain commented Jun 1, 2021

…dress

Proposed changes

will close #5951

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [BUG] stringfunction substring may cause heap-buffer-overflow #5951 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg self-assigned this Jun 2, 2021
@yangzhg yangzhg added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Jun 2, 2021
@morningman morningman merged commit d790cc6 into apache:master Jun 3, 2021
@stdpain stdpain deleted the fix_string_func branch July 6, 2021 11:59
stdpain added a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] stringfunction substring may cause heap-buffer-overflow

3 participants