Skip to content

[Bug] Fix problem for thread safety issues and setting the status of non-existent replica does not prompt any error message#6019

Merged
caiconghui merged 1 commit intoapache:masterfrom
caiconghui:admin_set_replica_status
Jun 18, 2021
Merged

[Bug] Fix problem for thread safety issues and setting the status of non-existent replica does not prompt any error message#6019
caiconghui merged 1 commit intoapache:masterfrom
caiconghui:admin_set_replica_status

Conversation

@caiconghui
Copy link
Contributor

@caiconghui caiconghui commented Jun 11, 2021

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…atus that does not exist does not prompt any error message
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/improvement kind/fix Categorizes issue or PR as related to a bug. labels Jun 18, 2021
@caiconghui caiconghui changed the title [Bug] Fix problem for thread safety issues and setting the replica status that does not exist does not prompt any error message [Bug] Fix problem for thread safety issues and setting the status of non-existent replica does not prompt any error message Jun 18, 2021
@caiconghui caiconghui merged commit ff47dc7 into apache:master Jun 18, 2021
@caiconghui caiconghui deleted the admin_set_replica_status branch August 30, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/catalog Issues or PRs related to catalog management kind/fix Categorizes issue or PR as related to a bug. kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] thread safety issues for replayBackendTabletsInfo and setting the replica status that does not exist does not prompt any error message

2 participants