Skip to content

[Enchancement] Validate data file after alter operation success#6022

Merged
morningman merged 1 commit intoapache:masterfrom
xinghuayu007:validate_file_after_alter
Jun 20, 2021
Merged

[Enchancement] Validate data file after alter operation success#6022
morningman merged 1 commit intoapache:masterfrom
xinghuayu007:validate_file_after_alter

Conversation

@xinghuayu007
Copy link
Contributor

@xinghuayu007 xinghuayu007 commented Jun 11, 2021

Proposed changes

Currently, after alter task finished, it only validate meta data of new tablet. It is also better to validate data file of new tablet. Because we found some tablet with beta format meta data, but alpha storage data after some bugs of alter operation. Look at the pic.

10 136 22 47 8040 api meta header 511088487 1278488007
小米办公  6

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinghuayu007 xinghuayu007 force-pushed the validate_file_after_alter branch from ba29f46 to 4e53b23 Compare June 11, 2021 12:53
@xinghuayu007 xinghuayu007 force-pushed the validate_file_after_alter branch from 4e53b23 to 7bd0fe8 Compare June 18, 2021 08:26
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 5dabf0b into apache:master Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants