[http][manager] Add manager related http interface.#6396
Merged
morningman merged 2 commits intoapache:masterfrom Aug 10, 2021
Merged
[http][manager] Add manager related http interface.#6396morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
The http interface includes getting cluster connection information, node information, node configuration information, batch modifying node configuration, and getting query profile.
morningman
added
api-review
morningman
reviewed
Aug 7, 2021
|
|
||
| package org.apache.doris.common.profile; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; |
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| static String concatUrl (Pair<String, Integer> ipPort, String path, Map<String, String> arguments) { |
Contributor
There was a problem hiding this comment.
Suggested change
| static String concatUrl (Pair<String, Integer> ipPort, String path, Map<String, String> arguments) { | |
| static String concatUrl(Pair<String, Integer> ipPort, String path, Map<String, String> arguments) { |
|
|
||
| package org.apache.doris.httpv2.rest.manager; | ||
|
|
||
| import com.fasterxml.jackson.annotation.JsonProperty; |
| public static final String AUTHORIZATION = "Authorization"; | ||
| private static final int HTTP_WAIT_TIME_SECONDS = 2; | ||
|
|
||
| public static final String CONFIG = "配置项"; |
Contributor
There was a problem hiding this comment.
We should only return column name in English. The multilanguage support should be done in Manager Frontend.
Contributor
Author
There was a problem hiding this comment.
Maybe we can change it to English in a later version.
|
|
||
| package org.apache.doris.httpv2.rest.manager; | ||
|
|
||
| import com.google.common.base.Strings; |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Nov 10, 2021
Encapsulate some http interfaces for better management and maintenance of doris clusters. The http interface includes getting cluster connection information, node information, node configuration information, batch modifying node configuration, and getting query profile. For details, please refer to the document: `docs/zh-CN/administrator-guide/http-actions/fe/manager/` Change-Id: I784eaeb572ecf1466bcfb7c540de8e0d06ff2842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Encapsulate some http interfaces for better management and maintenance of doris clusters.
The http interface includes getting cluster connection information, node information, node configuration information, batch modifying node configuration, and getting query profile.
For details, please refer to the document:
docs/zh-CN/administrator-guide/http-actions/fe/manager/Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...