Skip to content

[Memory] fix BUG crash when ~BitShufflePageDecoder destroys uninitialized chunk#7172

Merged
morningman merged 2 commits intoapache:masterfrom
xinyiZzz:bitshuffle_page_replace_faststring_fix_chunkfree_bug
Nov 23, 2021
Merged

[Memory] fix BUG crash when ~BitShufflePageDecoder destroys uninitialized chunk#7172
morningman merged 2 commits intoapache:masterfrom
xinyiZzz:bitshuffle_page_replace_faststring_fix_chunkfree_bug

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Nov 22, 2021

Proposed changes

Added a safe way to destroy Chunk.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Bug] ~BitShufflePageDecoder destroys uninitialized chunk #7171) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz xinyiZzz force-pushed the bitshuffle_page_replace_faststring_fix_chunkfree_bug branch 2 times, most recently from f7e4406 to 07a1de1 Compare November 22, 2021 11:41
@xinyiZzz xinyiZzz force-pushed the bitshuffle_page_replace_faststring_fix_chunkfree_bug branch from 07a1de1 to ef2bdc8 Compare November 22, 2021 12:44
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Nov 23, 2021
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 23, 2021
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit ad0d2b8 into apache:master Nov 23, 2021
@morningman morningman mentioned this pull request Nov 29, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ~BitShufflePageDecoder destroys uninitialized chunk

2 participants