[improvement] add a config repair_slow_replica#7423
Merged
morningman merged 2 commits intoapache:masterfrom Jan 4, 2022
Merged
[improvement] add a config repair_slow_replica#7423morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
morningman
reviewed
Dec 24, 2021
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
Please add ut for this case, you can refer to TabletRepairAndBalanceTest
yangzhg
force-pushed
the
auto_drop
branch
2 times, most recently
from
d29864c to
73de00f
Compare
when this config is true, Doris will try to delete the replica
with the largest number of versions, and then rebalance the replica.
Usually, when the number of versions of a certain replica is much higher
than that of other replicas, there are some problems with the current be's compilation.
Migrating to other machines can usually solve this problem.
Member
Author
done |
morningman
reviewed
Jan 3, 2022
fe/fe-core/src/main/java/org/apache/doris/clone/TabletScheduler.java
Outdated
Show resolved
Hide resolved
…r.java Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
pushed a commit
to 924060929/incubator-doris
that referenced
this pull request
Jan 4, 2022
…#7423) Add a new FE config `repair_slow_replica` when this config is true, Doris will try to delete the replica with the largest number of versions, and then rebalance the replica. Usually, when the number of versions of a certain replica is much higher then that of other replicas, there are some problems with the current be's compilation. Migrating to other machines can typically solve this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a config
repair_slow_replicawhen this config is true, Doris will try to delete the replica
with the largest number of versions, and then rebalance the replica.
Usually, when the number of versions of a certain replica is much higher
than that of other replicas, there are some problems with the current be's compilation.
Migrating to other machines can typically solve this problem.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...