[improvement](routine-load) Make routine load work with old kafka version#7630
Merged
caiconghui merged 6 commits intoapache:masterfrom Jan 10, 2022
Merged
[improvement](routine-load) Make routine load work with old kafka version#7630caiconghui merged 6 commits intoapache:masterfrom
caiconghui merged 6 commits intoapache:masterfrom
Conversation
EmmyMiao87
reviewed
Jan 6, 2022
| RETURN_IF_ERROR(set_conf("statistics.interval.ms", "0")); | ||
| RETURN_IF_ERROR(set_conf("auto.offset.reset", "error")); | ||
| RETURN_IF_ERROR(set_conf("api.version.request", "true")); | ||
| RETURN_IF_ERROR(set_conf("api.version.request", config::kafka_api_version_request)); |
Contributor
There was a problem hiding this comment.
Is It correct when api.version.request=true and broker.version.fallback=0.9 for new version of libdfkafka
Contributor
Author
There was a problem hiding this comment.
I will set broker.version.fallback=0.10.0 for default
EmmyMiao87
reviewed
Jan 6, 2022
|
|
||
| BloomFilter/Min/Max and other statistical information cache capacity | ||
|
|
||
| ### `kafka_api_version_request` |
Contributor
There was a problem hiding this comment.
Could you please update Routine Load doc ? https://doris.apache.org/master/zh-CN/administrator-guide/load-data/routine-load-manual.html#%E5%8E%9F%E7%90%86
caiconghui
changed the title
EmmyMiao87
reviewed
Jan 6, 2022
| 1. 支持无认证的 Kafka 访问，以及通过 SSL 方式认证的 Kafka 集群。 | ||
| 2. 支持的消息格式为 csv, json 文本格式。csv 每一个 message 为一行，且行尾**不包含**换行符。 | ||
| 3. 仅支持 Kafka 0.10.0.0(含) 以上版本。 | ||
| 3. 仅支持 Kafka 0.10.0.0(含) 以上版本。如果要使用 Kafka 0.10.0.0 以下版本 (0.9.0, 0.8.2, 0.8.1, 0.8.0)，需要修改 be 的配置，将 kafka_api_version_request 的值设置为false，将 kafka_broker_version_fallback 的值设置为要兼容的旧版本，使用旧版本的代价是routine load 的部分新特性无法使用，如根据时间设置 kafka 分区的 offset。 |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. 仅支持 Kafka 0.10.0.0(含) 以上版本。如果要使用 Kafka 0.10.0.0 以下版本 (0.9.0, 0.8.2, 0.8.1, 0.8.0)，需要修改 be 的配置，将 kafka_api_version_request 的值设置为false，将 kafka_broker_version_fallback 的值设置为要兼容的旧版本，使用旧版本的代价是routine load 的部分新特性无法使用，如根据时间设置 kafka 分区的 offset。 | |
| 3. 默认支持 Kafka 0.10.0.0(含) 以上版本。如果要使用 Kafka 0.10.0.0 以下版本 (0.9.0, 0.8.2, 0.8.1, 0.8.0)，需要修改 be 的配置，将 kafka_api_version_request 的值设置为false，将 kafka_broker_version_fallback 的值设置为要兼容的旧版本，使用旧版本的代价是routine load 的部分新特性无法使用，如根据时间设置 kafka 分区的 offset。 |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
morningman
approved these changes
Jan 10, 2022
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Henry2SS
pushed a commit
to Henry2SS/incubator-doris
that referenced
this pull request
Mar 16, 2022
…sion (apache#7630) Co-authored-by: caiconghui1 <caiconghui1@jd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Close related #7629 (replace it with issue number if it exists).
Describe the overview of changes, and introduce why we need it.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...