[fix](lateral-view) fix bugs of lateral view with CTE or where clause#7865
Merged
morningman merged 2 commits intoapache:masterfrom Jan 28, 2022
Merged
[fix](lateral-view) fix bugs of lateral view with CTE or where clause#7865morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
morningman
added
kind/fix
EmmyMiao87
reviewed
Jan 25, 2022
| // tbl1 | ||
| // tbl1 alias_tbl1 | ||
| // tbl1 alias_tbl1 lateral view explode_split(k1, ",") tmp1 as e1 | ||
| String tblName = name.toSql() + ((aliasSql != null) ? " " + aliasSql : ""); |
Contributor
There was a problem hiding this comment.
Which printing will be mainly affected after the change here?
|
|
||
| @Ignore | ||
| // errCode = 2, detailMessage = Unknown column 'e1' in 'table list' | ||
| public void testLaterViewWithCTEBug() throws Exception { |
Contributor
There was a problem hiding this comment.
Why ignore this single test
|
|
||
| @Ignore | ||
| // errCode = 2, detailMessage = Unknown column 'e1' in 'table list' | ||
| public void testLaterViewUnknowColumnBug() throws Exception { |
Contributor
There was a problem hiding this comment.
Why ignore this single test
Contributor
Author
There was a problem hiding this comment.
I leaves to you to fix it. LOL
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem Summary:
fix bugs of lateral view with CTE or where clause.
The error case can be found in newly added tests in
TableFunctionPlanTest.javaBut there are still some bugs not being fixed, so the unit test is annotated with @ignore
This PR contains the change is #7824 :
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...