Skip to content

Conversation

@Heluwe
Copy link

@Heluwe Heluwe commented Aug 28, 2018

What is the purpose of the change

Fix issue #1814

Brief changelog

dubbo-config-api/src/main/java/org/apache/dubbo/config/ApplicationConfig.java

Add variables Wait and their getter setter method.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@Heluwe Heluwe changed the title fix #1814 support graceful shutdown time be configured ApplicationConfig [Dubbo-issue1814][ Baiji-8] Add: xml conifg and ApplicationConfig for graceful-shutdown timeout #1814 Aug 28, 2018
private Map<String, String> parameters;

// customized graceful shutdown time
private Integer Wait;
Copy link
Member

@htynkn htynkn Aug 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the name should be wait or waitTime
  2. I only see the new field in config, but where do you use this new field?

@chickenlj chickenlj closed this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants