Skip to content

Conversation

@slowpao
Copy link
Contributor

@slowpao slowpao commented Feb 21, 2023

Fixes #3181

The AclService interface has been modified so that its methods can receive custom objects
AclService method field fix
image
image

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #3227 (d72a328) into master (a4bfa6b) will decrease coverage by 0.01%.
The diff coverage is 4.00%.

❗ Current head d72a328 differs from pull request most recent head a022cea. Consider uploading reports for the commit a022cea to get more accurate results

@@             Coverage Diff              @@
##             master    #3227      +/-   ##
============================================
- Coverage     13.05%   13.04%   -0.01%     
- Complexity     1154     1155       +1     
============================================
  Files           548      549       +1     
  Lines         28703    28732      +29     
  Branches       2848     2848              
============================================
+ Hits           3747     3749       +2     
- Misses        24633    24660      +27     
  Partials        323      323              
Impacted Files Coverage Δ
...ain/java/org/apache/eventmesh/runtime/acl/Acl.java 0.00% <0.00%> (ø)
.../org/apache/eventmesh/acl/impl/AclServiceImpl.java 100.00% <ø> (ø)
...va/org/apache/eventmesh/api/acl/AclProperties.java 6.89% <6.89%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 changed the title [ISSUE apache#3181] add AclPropeties - fix AclPropeties operate map m… [ISSUE #3181] add AclPropeties - fix AclPropeties operate map m… Feb 21, 2023
this.token = token;
}

public void setExtendedField(String key, Object object) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do you want to use this method

@xwm1992 xwm1992 changed the title [ISSUE #3181] add AclPropeties - fix AclPropeties operate map m… [ISSUE #3181] The method parameter properties of the aclService is adjusted to an object parameter, providing extended fields Feb 22, 2023
@xwm1992 xwm1992 merged commit a320625 into apache:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] The method parameter properties of the aclService is adjusted to an object parameter, providing extended fields

2 participants